Clean swift_flags array between targets in build-script-helper.py
#1168
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kylmakalle
approved these changes
Sep 5, 2022
SevaZhukov
approved these changes
Sep 5, 2022
AlexeyYarmolovich
approved these changes
Sep 5, 2022
Contributor
Author
|
@swift-ci please test |
Contributor
|
@swift-ci test |
Contributor
Author
|
@artemcm Thanks for the review, please merge the PR since I don't have write access to the repo. (yet 😂) |
Contributor
|
@azarovalex , this CI does not run the CMake build at all. Could you please also run a test from the main |
edymtt
approved these changes
Sep 8, 2022
Contributor
There was a problem hiding this comment.
If this helps, I've cross tested this PR in swiftlang/swift#60901 -- all jobs are green and swift-driver/swift-help have all archs as expected.
> lipo -archs Library/Developer/Toolchains/swift-PR-60901-293.xctoolchain/usr/bin/swift-driver
x86_64 arm64
> lipo -archs Library/Developer/Toolchains/swift-PR-60901-293.xctoolchain/usr/bin/swift-help
x86_64 arm64
Leaving to @artemcm to merge in case I've missed something
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Script
Utilities/build-script-helper.pydoesn't cleanswift_flagsarray while iterating on different targets, which results in the wrong-targetflag passed on the second iteration.Same with
base_cmake_flagsarray, it should not be shared between different targets.This bug currently blocks swift toolchain cross-compiling on M1 macs.